Do not ignore 'shouldAutoPlayVideo' function parameter in MediaPageViewController. #5789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
Currently when
MediaPageViewController.setCurrentItem
is invokedshouldAutoPlayVideo
parameter is ignored andMediaItemViewController.shouldAutoPlayVideo
property is always set to true inside function.In this PR I changed only part related to behaviour in
MediaPageViewController.setCurrentItem
but MediaPageViewController have several calls tosetCurrentItem
where this parameter is not used explicitly and its default tofalse
which may alter desired final behaviour as currentlyMediaItemViewController.shouldAutoPlayVideo
is always true. I would gladly change all places wheresetCurrentItem
but I do not know specs.